-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_sampling_planner_module): add autoware prefix #7392
Merged
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:refactor/path_sampling_planner-autoware_prefix
Jun 11, 2024
Merged
refactor(behavior_path_sampling_planner_module): add autoware prefix #7392
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:refactor/path_sampling_planner-autoware_prefix
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 10, 2024
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
and removed
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
labels
Jun 10, 2024
maxime-clem
force-pushed
the
refactor/path_sampling_planner-autoware_prefix
branch
from
June 10, 2024 03:59
69844d1
to
c18dede
Compare
maxime-clem
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
June 10, 2024 03:59
github-actions
bot
added
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
labels
Jun 10, 2024
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 10, 2024
maxime-clem
force-pushed
the
refactor/path_sampling_planner-autoware_prefix
branch
from
June 11, 2024 00:09
d772bd9
to
d30cbfc
Compare
takayuki5168
approved these changes
Jun 11, 2024
danielsanchezaran
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
maxime-clem
force-pushed
the
refactor/path_sampling_planner-autoware_prefix
branch
from
June 11, 2024 01:07
d30cbfc
to
18eb70c
Compare
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…7392) Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add autoware prefix to package name and put the code in the
autoware
namespace.Part of autowarefoundation/autoware#4569
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.